Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: spicedb tracer to debug check calls #798

Merged
merged 1 commit into from
Oct 25, 2024
Merged

test: spicedb tracer to debug check calls #798

merged 1 commit into from
Oct 25, 2024

Conversation

kushsharma
Copy link
Member

@kushsharma kushsharma commented Oct 21, 2024 •
edited
Loading

Config has additional flag to debug permission checks which can be enabled via spicedb.check_trace:true

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 10:05am

@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11516141659

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 30.826%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/serve.go 0 1 0.0%
internal/store/spicedb/relation_repository.go 0 8 0.0%
Totals Coverage Status
Change from base Build 11513126348: -0.008%
Covered Lines: 7623
Relevant Lines: 24729
💛 - Coveralls

@kushsharma
test: verify resource permissions are asserted correctly
3ccbe61 
Config has additional flag to debug permission checks which
can be enabled via `spicedb.check_trace:true`

Signed-off-by: Kush Sharma <[email protected]>
@kushsharma kushsharma marked this pull request as ready for review October 25, 2024 10:04
@kushsharma kushsharma changed the title test: verify resource permissions are asserted correctly test: spicedb tracer to debug check calls Oct 25, 2024
@kushsharma kushsharma merged commit e913c1c into main Oct 25, 2024
7 checks passed
@kushsharma kushsharma deleted the resource-role-access-test branch October 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anujk14 anujk14 anujk14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushsharma @coveralls @anujk14